This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Pings: track if "cody.contextFilters" field is configured in site config#62080
Merged
taras-yemets merged 6 commits intoApr 25, 2024
Merged
Conversation
taras-yemets
commented
Apr 22, 2024
Comment on lines
+706
to
+720
| // We don't bother doing this on Sourcegraph.com as it is expensive and not needed. | ||
| if !dotcom.SourcegraphDotComMode() { | ||
| r.GrowthStatistics, err = getAndMarshalGrowthStatisticsJSON(ctx, db) | ||
| if err != nil { | ||
| logFunc("getAndMarshalGrowthStatisticsJSON failed", log.Error(err)) | ||
| } | ||
|
|
||
| r.MigratedExtensionsUsage, err = getAndMarshalMigratedExtensionsUsageJSON(ctx, db) | ||
| if err != nil { | ||
| logFunc("getAndMarshalMigratedExtensionsUsageJSON failed", log.Error(err)) | ||
| } | ||
|
|
||
| r.CodyContextFiltersConfigured = conf.SiteConfig().CodyContextFilters != nil | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Refactor to put all enterprise-only pings into one block.
Contributor
…ilters-configured-to-pings
akalia25
approved these changes
Apr 25, 2024
akalia25
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I would still get the strat-eng-team to review and test. Thanks!
taras-yemets
referenced
this pull request
in sourcegraph/docs
Apr 25, 2024
1. Docs update on new pings data: - RFC - https://github.com/sourcegraph/sourcegraph/pull/62080 2. Add missing data on Cody providers pings. It existed on the old docs site, data is still reported via pings, so it should probably be mentioned on the pings page. Feel free to push back on this if we intentionally removed this data.
…ilters-configured-to-pings
taiyab
pushed a commit
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/61607
Test plan