This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove path verification for archive reader#61984
Merged
Merged
Conversation
eseliger
approved these changes
Apr 17, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
I'm assuming tests will fail now
Contributor
Author
|
@eseliger yep! Removed the tests as well. Will see if pipeline passes |
ggilmore
approved these changes
Apr 17, 2024
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Removes path verification for ArchiveReader calls since there are edge cases that we're not handling correctly. (cherry picked from commit 1bc52f6)
pjlast
added a commit
that referenced
this pull request
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes path verification for ArchiveReader calls since there are edge cases that we're not handling correctly.
Test plan
Manual tests that
src batch previewworks now.