This repository was archived by the owner on Sep 30, 2024. It is now read-only.
rbac: exclude PRODUCT_SUBSCRIPTIONS from user role, add testing for dotcom-mode#61893
Merged
Conversation
Contributor
|
Hey @bobheadxi Can we close this in favour of https://github.com/sourcegraph/sourcegraph/pull/61883 - I'm making changes to make declaring permissions for user role to be additive. |
bobheadxi
commented
Apr 15, 2024
| } | ||
|
|
||
| func clearTimeAndID(perms []*types.Permission) []*types.Permission { | ||
| func getDisplayNames(perms []*types.Permission) []string { |
Member
Author
There was a problem hiding this comment.
makes the diff significantly more readable
BolajiOlajide
approved these changes
Apr 15, 2024
jtibshirani
pushed a commit
that referenced
this pull request
Apr 15, 2024
…otcom-mode (#61893) See https://sourcegraph.slack.com/archives/C06TEEJLAET/p1712838707915619 (INC-292) - this should have been included as part of https://github.com/sourcegraph/sourcegraph/pull/60795 ## Test plan New integration test on `TestUpdatePermissions` for dotcom scenario to assert user perms in dotcom mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://sourcegraph.slack.com/archives/C06TEEJLAET/p1712838707915619 (INC-292) - this should have been included as part of https://github.com/sourcegraph/sourcegraph/pull/60795
Test plan
New integration test on
TestUpdatePermissionsfor dotcom scenario to assert user perms in dotcom mode.