This repository was archived by the owner on Sep 30, 2024. It is now read-only.
rbac: check for undefined permissions in PermissionsList#61737
Merged
Conversation
camdencheek
approved these changes
Apr 9, 2024
Contributor
Member
|
Tested locally that the |
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
add story book (cherry picked from commit d1169c6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#60795 introduced the concept of permissions that only exists on
Dotcom, however one thing we didn't take into consideration is how the frontend displays the role.Turns out we get
allPermissionsfrom the generatedgraphql-operations.tsfile which is statically generated at build time and doesn't know about permissions that only exist ondotcom.Test plan
Manual testing?
Added a storybook also.