Notices: Add customization for background color, text color, and text position.#61338
Conversation
…DismissibleAlert to accept and render backgroundColor
…sibleAlert to accept and render textColor
…missibleAlert to accept boolean for placing text in center of banner
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
|
@cla-bot check |
|
The GitHub CLA Bot is rechecking to see that you have signed the CLA - note that it may take up to 30 minutes for your response to be synchronized. |
|
LGTM - @RXminuS Recommend a review from the Search team and let's not forget docs for these changes @MaedahBatool |
|
@MaedahBatool I got some basic docs going https://github.com/sourcegraph/sourcegraph/pull/61338/commits/e54d93254846c35796d2bfb13be4d071ec3e6852 Would love your help and to double check I edited the correct things. |
Closes #59751
variantoption for Notices. Defaults to default option for position.styleOverridesoption to Notices with three fields:This means in the site-config a user can now specify notices as:
{ "notices": [ { "message": "THIS IS AN IMPORTANT NOTICE", "location": "top", "variant": "danger", "styleOverrides": { "backgroundColor": "#7f1d1d", "textColor": "#fecaca", "textCentered": true } } ] }resulting in the following notice
Test plan