in case we update the client again, could it be that their response parser breaks if it doesn't support that version anymore?

Not a blocker, this is still a good change, just a little scared.
Maybe we could use our HTTP recorder tests here to ensure that a newer version of the library is still able to parse the response alright?

I see this ClientOptions struct has a field called APIVersion - I assume this is not useful for us?

I see this ClientOptions struct has a field called APIVersion - I assume this is not useful for us?

Correct assumption: Request failed: this client doesn't support overriding its API version

Ah, unfortunate :( if the method looked like this, it would be configurable by us :(

// NewClientWithKeyCredential creates a new instance of Client that connects to an Azure OpenAI endpoint.
//   - endpoint - Azure OpenAI service endpoint, for example: https://{your-resource-name}.openai.azure.com
//   - credential - used to authorize requests with an API Key credential
//   - options - client options, pass nil to accept the default values.
func NewClientWithKeyCredential(endpoint string, credential *azcore.KeyCredential, options *ClientOptions) (*Client, error) {
	if options == nil {
		options = &ClientOptions{
// NEW:
			ClientOptions: azcore.ClientOptions{
				APIVersion: "2023-09-23",
			},
		}
	}

	authPolicy := runtime.NewKeyCredentialPolicy(credential, "api-key", nil)
	azcoreClient, err := azcore.NewClient(clientName, version, runtime.PipelineOptions{
// NEW:
		APIVersion: runtime.APIVersionOptions{Location: runtime.APIVersionLocationQueryParam, Name: "api-version"},
		PerRetry:   []policy.Policy{authPolicy},
	}, &options.ClientOptions)
	if err != nil {
		return nil, err
	}

	return &Client{
		internal: azcoreClient,
		clientData: clientData{
			endpoint: endpoint,
			azure:    true,
		},
	}, nil
}

in case we update the client again, could it be that their response parser breaks if it doesn't support that version anymore?

Totally this is far from ideal but better then reimplementing service principals, workload identity and the others. I'll add a backlog item to add a recorder test, it's a bit of a pain to get the format of the events.

works! thanks!

one last thing, since this doesn't wrap our httpcli transport, these requests won't be counted accordingly and cannot appear in the outgoing request logs. Not a blocker for now, but would be nice to wrap that in here.

Not adding for now since it's not a regression i'll add to the follow up issue along with parsing tests.