This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Batch changes: paginate when listing github apps#60383
Merged
Merged
Conversation
peterguy
reviewed
Feb 9, 2024
Co-authored-by: Peter Guy <peter.guy@sourcegraph.com>
peterguy
reviewed
Feb 9, 2024
BolajiOlajide
approved these changes
Feb 12, 2024
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
Because we were not paginating, we would end up deleting all installations when there were more than 30 (default page size). (cherry picked from commit 5d2f32d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we were not paginating, we would end up deleting all installations when there were more than 30 (default page size).
Test plan
Added a unit test and @BolajiOlajide manually tested the fix.
Walkthrough of Bolaji running a dead simple test