This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Search: increase default search limit#60114
Merged
Merged
Conversation
keegancsmith
approved these changes
Feb 5, 2024
keegancsmith
left a comment
Member
There was a problem hiding this comment.
I think monitoring stability of frontend/etc would also be useful here. I don't expect zoekt or search blitz to necessarily be effected. However, it might be easier for us to aggregate too much in the frontend (although I suppose streaming should avoid that). If there is a negative effect, I imagine it would mostly be dotcom specific.
414b6d6 to
b8751e3
Compare
Collaborator
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.3 5.3
# Navigate to the new working tree
cd .worktrees/backport-5.3
# Create a new branch
git switch --create backport-60114-to-5.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a8a6a855fb242a5e55f9d621575cdbc4714c6fae
# Push it to GitHub
git push --set-upstream origin backport-60114-to-5.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.3If you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-60114-to-5.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.3
|
Member
|
@camdencheek just in case you missed it, the backport failed. |
Member
Author
|
Ooh, thanks for the ping! I did, in fact, miss this |
camdencheek
added a commit
that referenced
this pull request
Feb 6, 2024
This increases the default search result limit from 2000 to 10000 (cherry picked from commit a8a6a85)
camdencheek
added a commit
that referenced
this pull request
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the default search limit once more from 2000 to 10000. This is the last planned increase. We have already saturated the display limit, so we should not see any significant increase in the payload sizes, which has been the source of any perf issues so far.
Test plan
Will watch search blitz as this rolls out. As with the previous increases, I do not expect a significant effect on performance.