Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

grpc: example: tweak example package to show off new retry logic#59218

Merged
ggilmore merged 1 commit into
mainfrom
12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic
Dec 23, 2023
Merged

grpc: example: tweak example package to show off new retry logic#59218
ggilmore merged 1 commit into
mainfrom
12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic

Conversation

@ggilmore

@ggilmore ggilmore commented Dec 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reply to https://github.com/sourcegraph/sourcegraph/pull/59111

This PR changes our example package to show off the new automatic retry logic, and its limitations.

Test plan

This is an example package that is not compiled into the main application.

I saw the expected behavior when running the run-server.sh and run-client.sh scripts.:

(snippet from the client)

INFO weather-client client/main.go:55 The call to GetCurrentWeather for New York failed. Retrying... {"attempt": 0, "error": "rpc error: code = Unavailable desc = simulated service outage"}

@cla-bot cla-bot Bot added the cla-signed label Dec 22, 2023
@github-actions github-actions Bot added the team/source Tickets under the purview of Source - the one Source to graph it all label Dec 22, 2023
This was referenced Dec 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ggilmore ggilmore requested review from a team, camdencheek and eseliger December 22, 2023 19:22
This was referenced Dec 22, 2023
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented Dec 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ggilmore ggilmore mentioned this pull request Dec 22, 2023
Merged
@ggilmore ggilmore force-pushed the 12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic branch 3 times, most recently from 429e25a to 0732547 Compare December 22, 2023 19:54
@ggilmore ggilmore force-pushed the 12-20-grpc_frontend_configuration_support_automatic_retries_GetConfig_is_idempotent_ branch from f21fa2e to b5a5dc9 Compare December 22, 2023 20:02
@ggilmore ggilmore force-pushed the 12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic branch from 0732547 to 0f61fcf Compare December 22, 2023 20:02
@ggilmore ggilmore force-pushed the 12-20-grpc_frontend_configuration_support_automatic_retries_GetConfig_is_idempotent_ branch from b5a5dc9 to 929706e Compare December 22, 2023 21:55
@ggilmore ggilmore force-pushed the 12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic branch from 0f61fcf to ad7b0a0 Compare December 22, 2023 21:55
@ggilmore ggilmore force-pushed the 12-20-grpc_frontend_configuration_support_automatic_retries_GetConfig_is_idempotent_ branch from 929706e to 0e83681 Compare December 22, 2023 22:10
@ggilmore ggilmore force-pushed the 12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic branch 2 times, most recently from 9a504aa to 85b831f Compare December 22, 2023 22:25
@ggilmore ggilmore force-pushed the 12-20-grpc_frontend_configuration_support_automatic_retries_GetConfig_is_idempotent_ branch from 0e83681 to d3cf8ab Compare December 22, 2023 23:08
Base automatically changed from 12-20-grpc_frontend_configuration_support_automatic_retries_GetConfig_is_idempotent_ to main December 22, 2023 23:15
@ggilmore ggilmore force-pushed the 12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic branch from 85b831f to fcbcb5e Compare December 22, 2023 23:18
eseliger
eseliger approved these changes Dec 23, 2023
View reviewed changes

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@ggilmore ggilmore merged commit 7a3ef7f into main Dec 23, 2023
@ggilmore ggilmore deleted the 12-22-grpc_example_tweak_example_package_to_show_off_new_retry_logic branch December 23, 2023 00:20
@ggilmore ggilmore mentioned this pull request Feb 6, 2024
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@camdencheek camdencheek Awaiting requested review from camdencheek

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger