This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: expose GitHub/GitLab topics in UI#58927
Merged
Merged
Conversation
This PR adds a resolver for topics and exposes them in the UI. Currently, we sync topics from GitHub and GitLab and it is possible to filter repositoroes by their topicss with the `repo:has.topic` filter. However, the synced topics are not visible in the UI, neither in the search results nor on the repo tree page.
d39f3b4 to
7f01950
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff bc35ae5...f9fdc6a.
|
camdencheek
reviewed
Dec 15, 2023
Comment on lines
+376
to
+381
| metadata, ok, err := unmarshalMetadata(s.logger, typ, metadataBytes) | ||
| if err != nil { | ||
| return err | ||
| } else if ok { | ||
| r.Topics = GetTopics(metadata) | ||
| } |
Member
There was a problem hiding this comment.
There is a virtual column on the repo table called topics that you can just query for this info. We should use that.
Member
Author
There was a problem hiding this comment.
Oops. I didn't see that. That makes things a bit tidier.
camdencheek
approved these changes
Dec 15, 2023
camdencheek
left a comment
Member
There was a problem hiding this comment.
This looks great, thank you!
| const showRepoMetadata = enableRepositoryMetadata && !!metadata | ||
| const showExtraInfo = result.archived || result.fork || result.private | ||
|
|
||
| const metadataTags = !metadata |
Member
There was a problem hiding this comment.
I don't think we want to assert with ! here since we're doing a type-safe check with ... ? ... : ..., right? Same with topics below?
| <ExtraInfoSectionItemHeader title="Description" tooltip="Synchronized from the code host" /> | ||
| {repo.description && <Text>{repo.description}</Text>} | ||
| </ExtraInfoSectionItem> | ||
| <ExtraInfoSectionItem> |
Member
There was a problem hiding this comment.
Should this section only be rendered if the repo has topics? In particular, it seems odd to show a section for this, say, on Bitbucket.
Member
Author
There was a problem hiding this comment.
Should this section only be rendered if the repo has topics?
Done
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
Currently, we sync topics from GitHub and GitLab and it is possible to filter repositories by their topics with the `repo:has.topic` filter. However, unlike user-added metadata, the synced topics are not visible in the UI, neither for repo matches nor on the repo tree page. This means it is impossible for users to figure out which topics they can filter by. With this PR we display topics, such as "language" or "golang", in addition to user-added metadata for repo matches and on the repo tree page. ## Test plan Note: Our search language distinguishes between user provided metadata (has.meta) and automatically synced metadata (has.topic). - manual testing - I checked that clicking on a "topic" badge adds a "has.topic" filter, while clicking on a "metadata" badge add a "has.meta" filter - Adding and deleting metadata works like before - Topics and metadata are sorted alphabetically - Results without metadata or topics are displayed correctly - added new unit test (cherry picked from commit 7da4c4e)
stefanhengl
added a commit
that referenced
this pull request
Dec 22, 2023
Relates to #58927 test plan: just a doc change
stefanhengl
added a commit
that referenced
this pull request
Dec 22, 2023
Relates to #58927 test plan: just a doc change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we sync topics from GitHub and GitLab and it is possible to
filter repositories by their topics with the
repo:has.topicfilter.However, unlike user-added metadata, the synced topics are not visible in the UI,
neither for repo matches nor on the repo tree page. This means it is impossible
for users to figure out which topics they can filter by.
With this PR we display topics, such as "language" or "golang", in addition to
metadata (EG
fruit:banana) for repo matches and on the repo tree page (see screenshots).Search results
Repository tree page (right panel)
Test plan
Note: Our search language distinguishes between user provided metadata (has.meta) and automatically synced metadata (has.topic).