This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[bitbucket cloud] Support workspace access tokens#58465
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d9c1d28...f4a1ff3.
|
eseliger
approved these changes
Nov 24, 2023
eseliger
left a comment
Member
There was a problem hiding this comment.
Great work, so quick!
Can you make sure to start a backport so we can ship this next Wednesday for the customer? Thanks :)
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": ["url", "username", "appPassword"], | ||
| "required": ["url"], |
Member
There was a problem hiding this comment.
We could probably use a oneOf to make it require either username AND appPassword, or accessToken, but never none of the two, and never both.
If that takes less than 30 min, might be worth it for the improved UX of getting at least some validation that you're lacking some fields?
Contributor
Author
There was a problem hiding this comment.
Added it! much better now I think 😬
7d2876c to
f4a1ff3
Compare
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
(cherry picked from commit 85587e8)
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58321
This PR adds support for Bitbucket Cloud Premium Workspace access tokens.
A new code host config option is added:
accessToken, and when set instead ofusernameandappPassword, will be used to sync and clone repositories.Test plan
VCR test added.
Preview 🤩
Preview Link