This repository was archived by the owner on Sep 30, 2024. It is now read-only.
embeddings: fix default size limit#58262
Merged
Merged
Conversation
jtibshirani
approved these changes
Nov 10, 2023
jtibshirani
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Could you explain what the outcome of the bug would look like (in case others run into this problem and want to know if it fixes their symptoms?)
keegancsmith
approved these changes
Nov 14, 2023
keegancsmith
left a comment
Member
There was a problem hiding this comment.
changelog entry and backport?
Member
Author
If users define file filters without defining |
This fixes a bug where the default size limit for files was set to 0 if `FileFilters` were defined. Until this fix is released, a workaround is to always define `MaxFileSizeBytes` if `FileFitlers` are defined. Test plan: - new unit test
858bba7 to
ab804b9
Compare
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
This fixes a bug where the default size limit for files was set to 0 if `FileFilters` were defined. This had the consequence that all files were skipped if file filters were defined but `MaxFileSizeBytes` was not explicitly set to a value >0. Until this fix is released, a workaround is to always define `MaxFileSizeBytes` if `FileFitlers` are defined. Test plan: - new unit test (cherry picked from commit 44b7c75)
| - Fixed a bug where typing in the GraphQL editor in the Site Admin API console could cause the cursor to jump to the start of the editor. [#57862](https://github.com/sourcegraph/sourcegraph/pull/57862) | ||
| - The blame column no longer ignores whitespace-only changes by default. [#58134](https://github.com/sourcegraph/sourcegraph/pull/58134) | ||
| - Long lines now wrap correctly in the diff view. [#58138](https://github.com/sourcegraph/sourcegraph/pull/58138) | ||
| - Defining file filters for embeddings jobs no longer causes all files to be skipped if `MaxFileSizeBytes` isn't defined. [#58262](https://github.com/sourcegraph/sourcegraph/pull/58262) |
Member
There was a problem hiding this comment.
given you are backporting needs to be moved to 5.2.x unreleased sections?
Member
Author
There was a problem hiding this comment.
I wasn't sure how to handle this TBH. I thought it was preferable to have a clean merge and not assume the backport here. Probably overthinking it. I will take care that eventually things will make sense.
stefanhengl
referenced
this pull request
Nov 15, 2023
This moves the changelog entry from 5.3 to 5.2.x because in the meantime https://github.com/sourcegraph/sourcegraph/pull/58262 has been backported.
Merged
stefanhengl
referenced
this pull request
Nov 15, 2023
This moves the changelog entry from 5.3 to 5.2.x because in the meantime https://github.com/sourcegraph/sourcegraph/pull/58262 has been backported.
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
This fixes a bug where the default size limit for files was set to 0 if `FileFilters` were defined. This had the consequence that all files were skipped if file filters were defined but `MaxFileSizeBytes` was not explicitly set to a value >0. Until this fix is released, a workaround is to always define `MaxFileSizeBytes` if `FileFitlers` are defined. Test plan: - new unit test
vovakulikov
referenced
this pull request
Dec 12, 2023
This moves the changelog entry from 5.3 to 5.2.x because in the meantime https://github.com/sourcegraph/sourcegraph/pull/58262 has been backported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the default size limit for files was set to 0 if
FileFilterswere defined.Until this fix is released, a workaround is to always define
MaxFileSizeBytesifFileFiltersare defined.Test plan: