Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Notebooks]: Remove notepad UI from notebooks feature#58217

Merged
vovakulikov merged 2 commits into
mainfrom
vk/remove-notepad
Nov 9, 2023
Merged

[Notebooks]: Remove notepad UI from notebooks feature#58217
vovakulikov merged 2 commits into
mainfrom
vk/remove-notepad

Conversation

@vovakulikov

@vovakulikov vovakulikov commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Closes https://github.com/sourcegraph/sourcegraph/issues/57996

Test plan

  • Check that notebooks still works as expected
  • Check that search flow has no regressions

Preview 🤩

Preview Link

@vovakulikov vovakulikov requested review from a team and fkling November 8, 2023 22:13
@vovakulikov vovakulikov self-assigned this Nov 8, 2023
@cla-bot cla-bot Bot added the cla-signed label Nov 8, 2023
@sourcegraph-bot

sourcegraph-bot commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff cb60097...4595f03.

Notify File(s)
@fkling client/web/src/search/Notepad.module.scss
client/web/src/search/Notepad.story.tsx
client/web/src/search/Notepad.test.tsx
client/web/src/search/Notepad.tsx
client/web/src/search/results/StreamingSearchResults.tsx

@vovakulikov

Copy link
Copy Markdown
Contributor Author

And all these code logic we had in the initial main chunk (so all users, whenever they use notepad or not load this logic to their clients)

@sourcegraph-bot

sourcegraph-bot commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@camdencheek camdencheek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vovakulikov vovakulikov merged commit a6debeb into main Nov 9, 2023
@vovakulikov vovakulikov deleted the vk/remove-notepad branch November 9, 2023 17:28
vovakulikov added a commit that referenced this pull request Dec 12, 2023
* Remove notepad UI from notebooks feature

* Update CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notebooks: remove notepad

3 participants