This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: Fix suggestion being selected after applying one#58186
Merged
Conversation
Contributor
jasonhawkharris
approved these changes
Nov 14, 2023
vovakulikov
approved these changes
Nov 14, 2023
aadcee6 to
6aae1e4
Compare
This issue occurred when a suggestion was applied while the extension was waiting for additional suggestions from the server. There are various ways to fix this but the most robust one is to identify when a state update pertains to the current completion request and when it does not. This commit adds a new field to the `Query` object to make this possible. Whenever a new request is issues this field is assigned a new value, making it easy to identify when we should preserve the current suggestion selection.
6aae1e4 to
fc66150
Compare
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
This issue occurred when a suggestion was applied while the extension was waiting for additional suggestions from the server. There are various ways to fix this but the most robust one is to identify when a state update pertains to the current completion request and when it does not. This commit adds a new field to the `Query` object to make this possible. Whenever a new request is issues this field is assigned a new value, making it easy to identify when we should preserve the current suggestion selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57848
This issue occurred when a suggestion was applied while the extension was waiting for additional suggestions from the server.
There are various ways to fix this but the most robust one is to identify when a state update pertains to the current completion request and when it does not.
This commit adds a new field to the
Queryobject to make this possible. Whenever a new request is issues this field is assigned a new value, making it easy to identify when we should preserve the current suggestion selection.Test plan
A relatively reliable way to test this seems to be the following:
file:foof:o.-> The value gets inserted, the default suggestions are shown, none of the suggestions is selected.