This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Vscode extension: Delete vscode extension package #58023
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 3ecb4da...363c856.
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 3ecb4da...363c856.
|
Contributor
jasonhawkharris
approved these changes
Oct 31, 2023
jasonhawkharris
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Do we need a change log entry?
vovakulikov
added a commit
that referenced
this pull request
Dec 12, 2023
* Remove vscode from CI * Delete vscode package * Remove vscode dependencies * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the whole vscode integration package from our codebase, it removes all readme, CI jobs, ...etc. It's been a while since we did anything about this part of our codebase, but it still require some attention when we do something about search result page. This PR is first part of change, later we in follow up we would be able to move search result UI from shared and simplify its API.
Test plan