This repository was archived by the owner on Sep 30, 2024. It is now read-only.
grpc: remove zoekt-webserver specific feature flag#56302
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f7a1545...5b4d2c5.
|
d998122 to
cb7a8c5
Compare
grpc-zoekt webserver support has been running successfully on sourcegraph.com for a while now, so there is no-need for two layers of feature flags here. sourcegraph.com will speak zoekt-webserver via gRPC when the main conf.IsGRPCEnabled setting is set to true (like every other service).
cb7a8c5 to
5b4d2c5
Compare
eseliger
approved these changes
Aug 31, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1 5.1
# Navigate to the new working tree
cd .worktrees/backport-5.1
# Create a new branch
git switch --create backport-56302-to-5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c08dcbc1158f9359660a768b335a03c7d6a45f4
# Push it to GitHub
git push --set-upstream origin backport-56302-to-5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1Then, create a pull request where the |
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
(cherry picked from commit 7c08dcb)
keegancsmith
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc-zoekt webserver support has been running successfully on sourcegraph.com for a while now, so there is no need for two layers of feature flags here.
sourcegraph.com will speak zoekt-webserver via gRPC when the main conf.IsGRPCEnabled setting is set to true (like every other service).
Test plan
CI