This repository was archived by the owner on Sep 30, 2024. It is now read-only.
conf: grpc: support silent retries if frontend isn't ready yet#56217
Merged
Conversation
66c0ebc to
43d0ba9
Compare
unknwon
approved these changes
Aug 25, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1 5.1
# Navigate to the new working tree
cd .worktrees/backport-5.1
# Create a new branch
git switch --create backport-56217-to-5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 396ef1fd02652f2cd55e2ce949dd24d8ce17bc72
# Push it to GitHub
git push --set-upstream origin backport-56217-to-5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1Then, create a pull request where the |
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
(cherry picked from commit 396ef1f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://sourcegraph.slack.com/archives/C04HCK4K3DL/p1691782868033789
Our configuration package has logic to automatically retry requests if any of them fail. However, on startup, it's likely the case that any given client will start before the frontend configuration server fully initializes. In the HTTP path, we had logic to "ignore" logging connection errors that occur during this initialization peroid.
We regressed on this behavior when we introduced gRPC powered site configuration in #55648. This PR adds similar logic for gRPC to reduce the logspam on startup.
Test plan
Manual testing.
sg startfrom scratch withSRC_GRPC_ENABLE_CONF: "true"set in yoursg.config.yaml.See errors like the following pop up in your terminal:
sg startagain with withSRC_GRPC_ENABLE_CONF: "true"set in yoursg.config.yaml.The above errors (
unable to fetch new configuration: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp [::1]:3090: connect: connection refused\"") are no longer present.