This repository was archived by the owner on Sep 30, 2024. It is now read-only.
backport 5.1: update zoekt - Removal of RepositoryRankRequest, include ngram sort optimization#56200
Merged
Conversation
Member
|
GH isn't happy. Are you basing this PR on the latest 5.1 branch? |
Member
|
@burmudar FYI I cherry-picked in a license check PR to https://github.com/sourcegraph/sourcegraph/pull/56088. Should we hold off on that PR and just focus on this one? |
Contributor
Author
Contributor
Contributor
Author
|
keegancsmith
approved these changes
Aug 24, 2023
Main motivation is to see the effect on performance for attribution search. Note that this included a bump in the otel version used since zoekt is using a new version. This had a bit of a cascading effect on our third party deps since they removed a package. So this bumps most 3rd party packages that directly interacted with otel. The changed commits are sourcegraph/zoekt@7643f3b...45f608f - a176bde1a3 go get -u -t ./... - e2e8aede00 Fix template documentation comments - 25c1ea5177 all: observe missing Stats RegexpsConsidered and FlushReason - 9abbb8b0d3 zoekt-indexserver: Prevent invalid config from causing an NPE - 008a775ba8 zoekt-indexserver: use value format directive for bad conf warning - f9d3a0e2e4 zoekt: add fgprof for full profiling - 3d0bdd5c9c remove ngram offset code - 45f608ff95 sort ngrams before looking them up Test Plan: tested in the zoekt repo. Our CI will handle the dep updates. I eyeballed them and they all look low risk. Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr>
This endpoint was unused which was why it was removed in Zoekt. The changes from Zoekt included in this dep bump: - 1686b50d50 indexserver: remove unused GetRepoRank - 7078a585a9 shards: populate RepoList.Stats.Repos - b9e6d9433e zoekt-indexserver: Check stderr for git fetch - 93f7b0c983 matchtree: capture Stats before pruning - 7643f3b313 matchiter: capture metric NgramLookups Test Plan: CI
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 974669e...74d0675.
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 974669e...74d0675.
|
Member
|
@ggilmore, this PR is obsoleted by https://github.com/sourcegraph/sourcegraph/pull/56077, right? |
Member
|
Oh wait. That only backports one of the two commits |
Contributor
|
No. This includes the ngram PR as well. This PR only techincally includes bazel configuration changes from https://github.com/sourcegraph/sourcegraph/pull/56077, see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined backport of the following:
Test plan
Green CI and testing backcompat locally