This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix: Repo embedding scheduler job routine as internal actor#55698
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ea67924...bc018ca.
|
camdencheek
approved these changes
Aug 9, 2023
| workCtx := actor.WithInternalActor(context.Background()) | ||
| return []goroutine.BackgroundRoutine{ | ||
| newRepoEmbeddingScheduler(ctx, gitserver.NewClient(db), db, repo.NewRepoEmbeddingJobsStore(db)), | ||
| newRepoEmbeddingScheduler(workCtx, gitserver.NewClient(db), db, repo.NewRepoEmbeddingJobsStore(db)), |
Member
There was a problem hiding this comment.
Just to double check, have you actually tested this with a private repo? It's not immediately obvious that the context passed in is the same that's used for actually running the background goroutine
Member
|
Beat me to it by like 2 minutes! |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1 5.1
# Navigate to the new working tree
cd .worktrees/backport-5.1
# Create a new branch
git switch --create backport-55698-to-5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ef63a4f9ecd8913a191bc5e5d562b80d46da527b
# Push it to GitHub
git push --set-upstream origin backport-55698-to-5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1Then, create a pull request where the |
camdencheek
added a commit
that referenced
this pull request
Aug 10, 2023
…actor (#55698) (#55701) We received reports of repositories never getting scheduled for embedding jobs despite the filter / pattern preview showing repos that match. In both cases linked private repos appear to be impacted. After fetching repo ids from `GetEmbeddableRepos` we then make another fetch for getting the repo names for those repo ids. This read operation is where we appear to end up missing out on some repos because we are not an internal actor and therefore we must have permissions to the repos that we want `List`ed. When we aren't authorized for any repos then we end up never scheduling those repos since we never got the repo names. (cherry picked from commit ef63a4f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received reports in slack of repositories never getting scheduled for embedding jobs despite the filter / pattern preview showing repos that match.
In both cases linked private repos appear to be impacted. After fetching repo ids from
GetEmbeddableReposwe then make another fetch for getting the repo names for those repo ids. This read operation is where we appear to end up missing out on some repos because we are not an internal actor and therefore we must have permissions to the repos that we wantListed. When we aren't authorized for any repos then we end up never scheduling those repos since we never got the repo names.Test plan
N/A