Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

executors: Be able to add annotations to job pods#55361

Merged
Piszmog merged 2 commits into
mainfrom
rc/executor-pod-annotations
Jul 27, 2023
Merged

executors: Be able to add annotations to job pods#55361
Piszmog merged 2 commits into
mainfrom
rc/executor-pod-annotations

Conversation

@Piszmog

@Piszmog Piszmog commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Be able to add annotations to Pods spawned by Jobs.

Test plan

Unit tests and manual testing.

Screenshot 2023-07-27 at 09 11 23

@Piszmog Piszmog requested a review from a team July 27, 2023 15:14
@cla-bot cla-bot Bot added the cla-signed label Jul 27, 2023
@sourcegraph-bot

sourcegraph-bot commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 8cb61f8...7eb3d41.

Notify File(s)
@efritz enterprise/cmd/executor/internal/config/config.go
enterprise/cmd/executor/internal/config/config_test.go
enterprise/cmd/executor/internal/run/util.go
enterprise/cmd/executor/internal/worker/command/kubernetes.go
enterprise/cmd/executor/internal/worker/command/kubernetes_test.go
@sourcegraph/delivery doc/admin/executors/deploy_executors_kubernetes.md

@sanderginn sanderginn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piszmog Piszmog merged commit ff34244 into main Jul 27, 2023
@Piszmog Piszmog deleted the rc/executor-pod-annotations branch July 27, 2023 17:31
github-actions Bot pushed a commit that referenced this pull request Jul 27, 2023
Be able to add annotations to Pods spawned by Jobs.

## Test plan

Unit tests and manual testing.

![Screenshot 2023-07-27 at 09 11
23](https://github.com/sourcegraph/sourcegraph/assets/38407415/eb267a71-4793-46fa-8988-e8ff56de3a39)

(cherry picked from commit ff34244)
MaedahBatool pushed a commit that referenced this pull request Jul 28, 2023
Be able to add annotations to Pods spawned by Jobs.

## Test plan

Unit tests and manual testing.

![Screenshot 2023-07-27 at 09 11
23](https://github.com/sourcegraph/sourcegraph/assets/38407415/eb267a71-4793-46fa-8988-e8ff56de3a39)
coury-clark pushed a commit that referenced this pull request Aug 1, 2023
)

Be able to add annotations to Pods spawned by Jobs.

## Test plan

Unit tests and manual testing.

![Screenshot 2023-07-27 at 09 11
23](https://github.com/sourcegraph/sourcegraph/assets/38407415/eb267a71-4793-46fa-8988-e8ff56de3a39)
 <br> Backport ff34244 from #55361

Co-authored-by: Randell Callahan <piszmogcode@gmail.com>
davejrt pushed a commit that referenced this pull request Aug 9, 2023
Be able to add annotations to Pods spawned by Jobs.

## Test plan

Unit tests and manual testing.

![Screenshot 2023-07-27 at 09 11
23](https://github.com/sourcegraph/sourcegraph/assets/38407415/eb267a71-4793-46fa-8988-e8ff56de3a39)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants