This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[github app] Encode App baseURL in state instead of using Referer#55305
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 9a01c36...5136d1b.
|
kopancek
approved these changes
Jul 26, 2023
Contributor
While I was writing this comment the unit test magically appeared. 👏 🙇 |
Contributor
BolajiOlajide
approved these changes
Jul 26, 2023
eseliger
approved these changes
Jul 26, 2023
eseliger
left a comment
Member
There was a problem hiding this comment.
should we backport for todays patch?
sashaostrikov
approved these changes
Jul 26, 2023
BolajiOlajide
pushed a commit
that referenced
this pull request
Jul 26, 2023
…ing Referer (#55307) Firefox's default settings do not forward Referer headers for privacy reasons. This means that GitHub App setups fail when done using Firefox. This PR adds the GitHub App's base url to the state we store in Redis, so that we no longer rely on the browser sending the Referer header. ## Test plan Tests updated. <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport 02ee893 from #55305
MaedahBatool
pushed a commit
that referenced
this pull request
Jul 28, 2023
davejrt
pushed a commit
that referenced
this pull request
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox's default settings do not forward Referer headers for privacy reasons. This means that GitHub App setups fail when done using Firefox.
This PR adds the GitHub App's base url to the state we store in Redis, so that we no longer rely on the browser sending the Referer header.
Test plan
Tests updated.