This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove broken federation feature#55161
Merged
Merged
Conversation
Only today did I learn about the "Federation" feature: https://docs.sourcegraph.com/admin/federation/public_repositories It's supposed to redirect users from private instances to sourcegraph.com. But it has been broken since at least a year: https://github.com/sourcegraph/sourcegraph/issues/38263#issuecomment-1205110145 It's also confusing. Here's my proposal to remove it.
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff b98ca76...74343a6.
|
sashaostrikov
approved these changes
Jul 20, 2023
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
The whole feature in under 70 lines? 😁
UN:shipit: (un-ship it)
BolajiOlajide
approved these changes
Jul 20, 2023
varsanojidan
approved these changes
Jul 20, 2023
eseliger
reviewed
Jul 20, 2023
Contributor
Contributor
Author
|
Added changelog and only deprecated the value instead of removing it. |
eseliger
reviewed
Jul 20, 2023
eseliger
approved these changes
Jul 20, 2023
Contributor
Author
|
@sqs I merged this without waiting for approval. I think this feature being broken for over 1 year & no engineer here knowing about the feature at all, plus it just adding just enough complexity to make the code hard to understand is a good reason to remove it. |
Closed
MaedahBatool
pushed a commit
that referenced
this pull request
Jul 28, 2023
Only today did I learn about the "Federation" feature: https://docs.sourcegraph.com/admin/federation/public_repositories It's supposed to redirect users from private instances to sourcegraph.com. But it has been broken since at least a year: https://github.com/sourcegraph/sourcegraph/issues/38263#issuecomment-1205110145 It's also confusing. Here's my proposal to remove it. ## Test plan - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only today did I learn about the "Federation" feature: https://docs.sourcegraph.com/admin/federation/public_repositories
It's supposed to redirect users from private instances to sourcegraph.com.
But it has been broken since at least a year: https://github.com/sourcegraph/sourcegraph/issues/38263#issuecomment-1205110145
It's also confusing.
Here's my proposal to remove it.
Test plan