This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Use repeated --credentials flag in coursier#55113
Merged
Merged
Conversation
Instead of the multi-line env variable we used before, which is not escaped correctly and newlines are simply removed causing credentials problems.
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d9c9fa8...dae2cfe.
|
eseliger
reviewed
Jul 19, 2023
olafurpg
approved these changes
Jul 19, 2023
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍🏻 Thank you for spotting the root issue! Feel free to merge if local testing validates the fix works as intended.
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Instead of the multi-line env variable we used before, which is not escaped correctly and newlines are simply removed causing credentials problems. (cherry picked from commit 462e5ec)
keynmol
added a commit
that referenced
this pull request
Jul 25, 2023
BolajiOlajide
added a commit
that referenced
this pull request
Jul 25, 2023
MaedahBatool
pushed a commit
that referenced
this pull request
Jul 28, 2023
Instead of the multi-line env variable we used before, which is not escaped correctly and newlines are simply removed causing credentials problems.
MaedahBatool
pushed a commit
that referenced
this pull request
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the multi-line env variable we used before, which is not escaped correctly and newlines are simply removed causing credentials problems.
Test plan
To test these changes, I did the following:
They have different credentials.
Launch two file proxies with basic auth
For some reason I wrote a Scala script for that, so I'll keep it here for the future: https://gist.github.com/keynmol/25268b030c95eff2f073d49763f0fefc
Verify that both proxies are being hit, and files being served
For some reason I see some requests being sent without auth at first, which might be a quirk of coursier - doesn't seem to affect the results.
So overall, I believe this is working well.