This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[gitlab] Support custom GitLab SSO sign-on URLs#54957
Merged
Merged
Conversation
mrnugget
reviewed
Jul 14, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4ae7ee4...4ee4c96.
|
kopancek
approved these changes
Jul 14, 2023
kopancek
left a comment
Contributor
There was a problem hiding this comment.
Nice, I like this approach 👍
eseliger
approved these changes
Jul 14, 2023
4d8c974 to
4305f52
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
(cherry picked from commit b2c7b5a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50879
Adds a new Auth provider configuration option for GitLab auth providers,
ssoURL. This is an optional URL that points to a GitLab group's SSO sign-in page, and adds the regular OAuth URL as aredirectparameter. So users will first sign in to GitLab using their SSO, then it will redirect them to the normal OAuth flow.GitLab's normal OAuth flow for groups that have SSO enabled is broken, and users will be redirected to the normal GitLab sign-in page where they have to provide a username and password, which they don't have, because they use SSO.
Imagine the following scenario:
This is super annoying, and it's not intuitive how to solve this yourself unless you've been through this before.
Test plan
Add unit test for new handler