This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[fix] perms jobs not being scheduled if there is not already a job#54278
Merged
Conversation
Previously, the `usersWithOldestPermsQuery` and `reposWithOldestPermsQuery` relied solely on the permission_sync_jobs table. If there was no row for the user or repo, this query would not return that user anymore. This resulted in users/repos never being scheduled for a permission sync in cases when a job was not created previously (or jobs table was truncated). Attempted to fix the queries by including those users/repos that do not have any record in the jobs table and putting these users/repos at the top of the queue.
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 98e5049...c3d0fb6.
|
kopancek
commented
Jun 27, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
…54278) Previously, the `usersWithOldestPermsQuery` and `reposWithOldestPermsQuery` relied solely on the permission_sync_jobs table. If there was no row for the user or repo, this query would not return that user anymore. This resulted in users/repos never being scheduled for a permission sync in cases when a job was not created previously (or jobs table was truncated). Attempted to fix the queries by including those users/repos that do not have any record in the jobs table and putting these users/repos at the top of the queue. ## Test plan unit test modified, tested locally (cherry picked from commit f3fd139)
keegancsmith
pushed a commit
that referenced
this pull request
Jun 27, 2023
…lready a job (#54281) Previously, the `usersWithOldestPermsQuery` and `reposWithOldestPermsQuery` relied solely on the permission_sync_jobs table. If there was no row for the user or repo, this query would not return that user anymore. This resulted in users/repos never being scheduled for a permission sync in cases when a job was not created previously (or jobs table was truncated). Attempted to fix the queries by including those users/repos that do not have any record in the jobs table and putting these users/repos at the top of the queue. ## Test plan unit test modified, tested locally <br> Backport f3fd139 from #54278 Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
usersWithOldestPermsQueryandreposWithOldestPermsQueryrelied solely on the permission_sync_jobs table. If there was no row for the user or repo, this query would not return that user anymore.This resulted in users/repos never being scheduled for a permission sync in cases when a job was not created previously (or jobs table was truncated).
Attempted to fix the queries by including those users/repos that do not have any record in the jobs table and putting these users/repos at the top of the queue.
Test plan
unit test modified, tested locally