This repository was archived by the owner on Sep 30, 2024. It is now read-only.
bzl: fix backcompat buildfiles breakage#54047
Merged
Merged
Conversation
burmudar
approved these changes
Jun 23, 2023
willdollman
pushed a commit
that referenced
this pull request
Jun 23, 2023
OTEL stuff moved packages around, which messed our ability to build old code. This is happening because we're building the old code with our new `deps.bzl` (there isn't really an easy way around that for now). ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> CI, backcompat test passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTEL stuff moved packages around, which messed our ability to build old code. This is happening because we're building the old code with our new
deps.bzl(there isn't really an easy way around that for now).Test plan
CI, backcompat test passed.