This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: Fix package set construction#53763
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 9f89d65...fac3f16.
|
Strum355
approved these changes
Jun 20, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
(cherry picked from commit 8231c68)
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're neglecting to add some packages to the
lsif_packagestable. Tracked this down to thepackageSetmap having false values when they should've been true.Turns out that when processing documents in a particular order we can re-assign false over a true assignment in this map, counting definitions instead as references. This makes it unable to be the target of a jump-to-definition operation.
This PR fixes it so that we don't mark definitions as references once marked as definition.
Test plan
Ran QA tests locally.