This repository was archived by the owner on Sep 30, 2024. It is now read-only.
github app: add note that only org owners can view org installations#53611
Merged
Conversation
Contributor
pjlast
approved these changes
Jun 19, 2023
coury-clark
pushed a commit
that referenced
this pull request
Jun 20, 2023
… installations (#53790) @st0nebraker [pointed out](https://github.com/sourcegraph/sourcegraph/pull/53212#pullrequestreview-1475310777) in a previous PR that the "View on GitHub" link for GitHub App installations only works if you are able to administer that installation, e.g. that you are an org owner for the org where it's installed, if it's on an org, or that you are the user. If we had this information, we could just hide the button for installations the user can't actually view, but since we don't, we thought it could help to add a note instead. ## Test plan Just an in-product docs change. Verified the text appears on the GitHub App page. <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport be1ff32 from #53611 Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@st0nebraker pointed out in a previous PR that the "View on GitHub" link for GitHub App installations only works if you are able to administer that installation, e.g. that you are an org owner for the org where it's installed, if it's on an org, or that you are the user. If we had this information, we could just hide the button for installations the user can't actually view, but since we don't, we thought it could help to add a note instead.
Test plan
Just an in-product docs change. Verified the text appears on the GitHub App page.