This repository was archived by the owner on Sep 30, 2024. It is now read-only.
don't use dbutil.NewNullString when inserting into gitserver_repos_sync_output#53579
Merged
Conversation
Not sure why I was using that when the column is non-nullable.
camdencheek
approved these changes
Jun 16, 2023
camdencheek
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the quick fix!
55 tasks
Contributor
|
Thanks Peter! Hit this locally, too, and was pleasantly surprised to find you'd already fixed it up. ❤️ |
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
…_sync_output` (#53579) Not sure why I was using `dbutil.NewNullString` when the column is non-nullable. Too much copy pasta. Thanks for [the alert](https://github.com/sourcegraph/sourcegraph/pull/51598#issuecomment-1593866227), @camdencheek ## Test plan unit tests added re-clone a repository and verify that the last output shows up in the `Mirroring and cloning` page (click on the kebab menu on the repository and choose `Last sync log`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why I was using
dbutil.NewNullStringwhen the column is non-nullable. Too much copy pasta.Thanks for the alert, @camdencheek
Test plan
unit tests added
re-clone a repository and verify that the last output shows up in the
Mirroring and cloningpage (click on the kebab menu on the repository and chooseLast sync log