This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Search: enable cross-repo ranking by default#53031
Merged
Merged
Conversation
1e1c9ac to
02c880e
Compare
02c880e to
dc8d1cd
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 3a43d1f...22fd5bc.
|
Contributor
jtibshirani
commented
Jun 6, 2023
|
|
||
| <div className={styles.expander} /> | ||
|
|
||
| {rankingEnabled && ( |
Contributor
Author
There was a problem hiding this comment.
Goodbye ranking toggle!
Contributor
There was a problem hiding this comment.
Ha! It served us well 😄
cesrjimenez
approved these changes
Jun 6, 2023
keegancsmith
approved these changes
Jun 7, 2023
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
This PR updates the `search-ranking` feature flag to default to 'true'. This greatly improves the result ranking search ranking for cross-repo searches, or for very large repos. We feel ready to GA this since it's been running successfully on dot com and S2 for several months, and had a successful customer trial. Note: this enables only **part** of the "Intelligent ranking" feature. The code intel jobs to produce file ranks are still not enabled by default. We'll make a separate "GA" decision for those jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
search-rankingfeature flag to default to 'true'. This greatly improves the result ranking search ranking for cross-repo searches, or for very large repos.We feel ready to GA this since it's been running successfully on dot com and S2 for several months, and had a successful customer trial.
Note: this enables only part of the "Intelligent ranking" feature. The code intel jobs to produce file ranks are still not enabled by default. We'll make a separate "GA" decision for those jobs.
Test plan
Sourcegraph CI (already several tests exercising ranking). Dogfooding on dot com, S2, customer site.