This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: filter github apps for domain#52330
Merged
BolajiOlajide merged 0 commit intoMay 26, 2023
Merged
Conversation
Collaborator
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits b801193 and 60d130d or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 54fb51bffdd0c2776f85033db08ad28b3a8a31f0...b8011939a6c3f5e36ae5591e90e78237c480a224.
|
Contributor
ed5ba97 to
f1ac900
Compare
courier-new
approved these changes
May 24, 2023
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, just had a couple minor suggestions. 🙂
Comment on lines
+9
to
+10
| query GitHubApps($domain: String) { | ||
| gitHubApps(domain: $domain) { |
Contributor
There was a problem hiding this comment.
No strong feelings about this, but we could also hardcode in the repos domain for this query string to be clearer about its purpose, since presumably we'll define a separate query with separate fields for the Batch Changes page.
102e7cd to
882f2bd
Compare
courier-new
reviewed
May 24, 2023
courier-new
reviewed
May 24, 2023
c741a7a to
6b201c9
Compare
courier-new
approved these changes
May 25, 2023
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Amazingggg 👏 Just had some minor nits, all of which I tried to provide with suggestions so hopefully you can just commit them and be on your way. 🎉
courier-new
reviewed
May 26, 2023
courier-new
reviewed
May 26, 2023
58b5be5 to
b801193
Compare
BolajiOlajide
commented
May 26, 2023
| webhookUUID, err := uuid.Parse(stateDeets.WebhookUUID) | ||
| if err != nil { | ||
| http.Error(w, fmt.Sprintf("Bad request, could not parse webhook UUID: %s", err.Error()), http.StatusBadRequest) | ||
| http.Error(w, fmt.Sprintf("Bad request, could not parse webhook UUID: %v", err), http.StatusBadRequest) |
Contributor
Author
There was a problem hiding this comment.
I changed this so we don't have a lot of err.Error() everywhere, it's basically the same as what we had before.
The %v formatting directive will print the error message.
I added a sample here for you to check @st0nebraker .
BolajiOlajide
commented
May 26, 2023
| return nil, nil | ||
| } | ||
| switch *s { | ||
| switch strings.ToUpper(*s) { |
Contributor
Author
There was a problem hiding this comment.
I updated this to convert the domain to a UPPER case string because this method is being used in the route handler for /redirect and in that handler, the domain is lowercased.
BolajiOlajide
added a commit
that referenced
this pull request
May 26, 2023
Co-authored-by: Becca Steinbrecher <beccasteinbrecher@gmail.com> Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com> Closes [#52324](https://github.com/sourcegraph/sourcegraph/issues/52324)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52324
Now that we have different GitHub apps for different domains, this PR adds a filtering mechanism so we don't get a conflict.
The initial UI work filters non-repos GitHub apps from the GitHub apps section in Site Admin settings
Test plan
We don't yet have a mechanism for creating non-repos GitHub apps for now, so for now, the steps to follow are as follows:
repos