Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

(feat) make "repository-metadata" feature flag enabled by default#52301

Merged
erzhtor merged 2 commits into
mainfrom
erzhtor/make-repository-metadata-feature-enabled-by-default
May 24, 2023
Merged

(feat) make "repository-metadata" feature flag enabled by default#52301
erzhtor merged 2 commits into
mainfrom
erzhtor/make-repository-metadata-feature-enabled-by-default

Conversation

@erzhtor

@erzhtor erzhtor commented May 23, 2023

Copy link
Copy Markdown
Contributor

Part of https://github.com/sourcegraph/pr-faqs/issues/96.

Test plan

  • sg start
  • Remove repository-metadata feature flag if exist
  • Search using select:repo, go to repo root page, all the repo metadata features should be enabled by default
  • Add repository-metadata=false feature flag
  • All the repository metadata related features should be disabled now

@erzhtor erzhtor requested review from a team, camdencheek, ryphil and toolmantim May 23, 2023 12:29
@erzhtor erzhtor self-assigned this May 23, 2023
@cla-bot cla-bot Bot added the cla-signed label May 23, 2023
@sourcegraph-bot

sourcegraph-bot commented May 23, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 4f4ced5...8dd380e.

Notify File(s)
@fkling client/web/src/search/results/StreamingSearchResults.tsx
client/web/src/search/results/export/SearchResultsCsvExportModal.tsx
@limitedmage client/web/src/search/results/StreamingSearchResults.tsx
client/web/src/search/results/export/SearchResultsCsvExportModal.tsx
@unknwon dev/gqltest/search_test.go

@sourcegraph-buildkite

sourcegraph-buildkite commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.00 kb) 0.00% (+0.00 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 8dd380e and c205ded or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@sourcegraph-bot

sourcegraph-bot commented May 23, 2023

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@sashaostrikov sashaostrikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@erzhtor erzhtor force-pushed the erzhtor/make-repository-metadata-feature-enabled-by-default branch 3 times, most recently from 6bc0dc7 to a532e66 Compare May 24, 2023 09:00
…epoMetadataSummary

(tests) add test for internal/usagestats/aggregated_repo_metadata.go/getAggregatedRrepoMetadataSummary
(ci) run bazel configure
@erzhtor erzhtor force-pushed the erzhtor/make-repository-metadata-feature-enabled-by-default branch from a532e66 to 8dd380e Compare May 24, 2023 12:19
@erzhtor erzhtor changed the title (feat) make "repository-metadata" feature flag be enabled by default (feat) make "repository-metadata" feature flag enabled by default May 24, 2023
@erzhtor erzhtor merged commit 2b36c6e into main May 24, 2023
@erzhtor erzhtor deleted the erzhtor/make-repository-metadata-feature-enabled-by-default branch May 24, 2023 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants