This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Return the output of the sync command in VCSSyncer::Fetch #51754
Merged
Conversation
Return the output of the command that was run to sync the repo, as well as the error. Including the output will support [issue 51236](https://github.com/sourcegraph/sourcegraph/issues/51236) by storing the output of the sync for the background syncs as well as the clones and manually-queued syncs. Including the backgorund syncs is important because if something changes and the repos aren't being updated, the output can help an admin figure out what the problem is.
sashaostrikov
approved these changes
May 11, 2023
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
It is still a draft, is it subject to change later?
Contributor
Author
|
Thanks @sashaostrikov ; it was still a draft just because I hadn't gotten back to it yet. :-) |
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a7c4ca0...14ff443.
|
cesrjimenez
pushed a commit
that referenced
this pull request
May 17, 2023
Administrating Perforce depot syncing in Sourcegraph is made much easier by being able to examine the output of the `p4-fusion` command. See [PR 51598](https://github.com/sourcegraph/sourcegraph/pull/51598) for details. This PR adds support for capturing the output when a background sync runs. Because it modifies the signature of `VSCSyncer`, it's being broken out into a separate PR. ## Test plan existing tests updated to support the returned output <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
peterguy
added a commit
that referenced
this pull request
May 24, 2023
cherry-picked #51754 and added (redacted) output capture from fetches.
peterguy
added a commit
that referenced
this pull request
Jun 13, 2023
cherry-picked #51754 and added (redacted) output capture from fetches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Administrating Perforce depot syncing in Sourcegraph is made much easier by being able to examine the output of the
p4-fusioncommand. See PR 51598 for details.This PR adds support for capturing the output when a background sync runs. Because it modifies the signature of
VSCSyncer, it's being broken out into a separate PR.Test plan
existing tests updated to support the returned output