This repository was archived by the owner on Sep 30, 2024. It is now read-only.
bazel: decouple web application bundle from integration tests modules#51560
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a990dd8...b549197.
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff a990dd8...b549197. No notifications. |
Contributor
48b2aea to
c9f2f84
Compare
c9f2f84 to
95c4671
Compare
jhchabran
approved these changes
May 9, 2023
d2aff7c to
b549197
Compare
BolajiOlajide
pushed a commit
that referenced
this pull request
May 10, 2023
…#51560) Make the web application bundle independent from the `//client/web/src/integration` and `//client/shared/src/testing`. It significantly slows down the Percy changes I iterate on locally. Previously they were connected via multiple mock files and the shared `isHotReloadEnabled` variable. The variable is redundant now, and the mock files are correctly moved to the `web_tests` target out of `web_lib`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Make the web application bundle independent from the
//client/web/src/integrationand//client/shared/src/testing. It significantly slows down the Percy changes I iterate on locally.Previously they were connected via multiple mock files and the shared
isHotReloadEnabledvariable. The variable is redundant now, and the mock files are correctly moved to theweb_teststarget out ofweb_lib.Test plan
CI