This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: edit search context with special characters results in 404#51196
Merged
Conversation
Escaped the path parameter to stop this from happening.
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits fc17a32 and d8f53d2 or learn more. Open explanation
|
sashaostrikov
approved these changes
Apr 27, 2023
coury-clark
pushed a commit
that referenced
this pull request
May 1, 2023
…ts in 404 (#51202) Escaped the path parameter to stop this from happening. fixes #50992 - #50992 ## Test plan Tested locally that it works as expected. Not sure if we want to extend the existing unit tests or work on a different fix. <br> Backport 128a0b9 from #51196 Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escaped the path parameter to stop this from happening.
fixes #50992
/causes a 404 #50992Test plan
Tested locally that it works as expected.
Not sure if we want to extend the existing unit tests or work on a different fix.