This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: do not return error when bitbucket server account is not found#51030
Merged
Conversation
This was causing unnecessary error logs. But there are cases, where this is completely normal, e.g. if a sourcegraph user does not have bitbucket server account linked. Do not return an error, as other providers also do not return an error in this case. Related: - #51024
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ff9af8b...08274df.
|
sashaostrikov
approved these changes
Apr 24, 2023
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me!
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
…51030) This was causing unnecessary error logs. But there are cases, where this is completely normal, e.g. if a sourcegraph user does not have bitbucket server account linked. Do not return an error, as other providers also do not return an error in this case. fixes #51024 - #51024 ## Test plan unit test changed (cherry picked from commit 0e59032)
coury-clark
pushed a commit
that referenced
this pull request
Apr 24, 2023
… is not found (#51033) This was causing unnecessary error logs. But there are cases, where this is completely normal, e.g. if a sourcegraph user does not have bitbucket server account linked. Do not return an error, as other providers also do not return an error in this case. fixes #51024 - #51024 ## Test plan unit test changed <br> Backport 0e59032 from #51030 Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing unnecessary error logs. But there are cases, where this is completely normal, e.g. if a sourcegraph user does not have bitbucket server account linked. Do not return an error, as other providers also do not return an error in this case.
fixes #51024
Test plan
unit test changed