This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cody aggregated ping additions.#50835
Merged
Merged
Conversation
unknwon
reviewed
May 3, 2023
unknwon
approved these changes
May 3, 2023
Contributor
|
Thank you for the followups! Let's wait for CI. |
Contributor
|
@nathan-downs - Looks like the test failed: https://buildkite.com/sourcegraph/sourcegraph/builds/216628#0187e1d5-4283-40ac-bddc-c1f357e7f0bc/340 |
akalia25
reviewed
May 3, 2023
akalia25
reviewed
May 3, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
May 3, 2023
## Test plan Verify by running locally and checking ping structure. Verify that payload is properly formed and submitted to pubsub topic. <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> --------- Co-authored-by: Joe Chen <joe@sourcegraph.com> (cherry picked from commit c5f62c0)
unknwon
pushed a commit
that referenced
this pull request
May 3, 2023
## Test plan Verify by running locally and checking ping structure. Verify that payload is properly formed and submitted to pubsub topic. <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport c5f62c0 from #50835 Co-authored-by: Nathan Downs <85511556+nathan-downs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
Verify by running locally and checking ping structure.
Verify that payload is properly formed and submitted to pubsub topic.