This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: allow repo iterators to be created over zero repos#50561
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ed6aa96...bc7c6a7.
|
coury-clark
approved these changes
Apr 17, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Currently insights that have resolve to matching no repos will fail the backfill because a repo iterator isn't allowed to be created for 0 repos. I don't see a reason why we need to disallow empty iterators. This removes that restriction. ## Test plan Unit test added Created an insight over 0 repos using repo search `repo:notarepo` - verified insight completed backfilling with zero data. <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> (cherry picked from commit c928f0a)
coury-clark
pushed a commit
that referenced
this pull request
Apr 17, 2023
… repos (#50745) Currently insights that have resolve to matching no repos will fail the backfill because a repo iterator isn't allowed to be created for 0 repos. I don't see a reason why we need to disallow empty iterators. This removes that restriction. ## Test plan Unit test added Created an insight over 0 repos using repo search `repo:notarepo` - verified insight completed backfilling with zero data. <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport c928f0a from #50561 Co-authored-by: Chris Warwick <christopher.warwick@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently insights that have resolve to matching no repos will fail the backfill because a repo iterator isn't allowed to be created for 0 repos. I don't see a reason why we need to disallow empty iterators. This removes that restriction.
Test plan
Unit test added
Created an insight over 0 repos using repo search
repo:notarepo- verified insight completed backfilling with zero data.