permissions-center: add statistics to Permissions Center.#50535
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits a380d7f and c9ddb0d or learn more. Open explanation
|
There was a problem hiding this comment.
This should also have polling based on the same localstorage.
AND you need to extract whole stats out into a separate component, as PermissionsSyncJobsTable is used on permissions info pages as well and there we don't need to poll stats.
So extract this in a separate component, pass polling boolean variable to that component and render that component inside this table component if minimal=false.
There was a problem hiding this comment.
Reduce the borders. This looks better and matches with the designs in figma
There was a problem hiding this comment.
one thing i forgot to mention. We should also mention total user & repo counts. 0/199 Failing users. like this
6ebd463 to
3b00e4e
Compare
There was a problem hiding this comment.
You can do setFilters((oldFilters)=> ({...oldFilters, state: newState}))
No need to accept both filters & setFilters in props.
There was a problem hiding this comment.
I guess we cannot do it here, because it's not the setter of a useState hook, which lets us do it, but it is a (partialData: Partial<T>) => void function of useURLSyncedState hook.
Or am I missing something?
0xnmn
left a comment
There was a problem hiding this comment.
May be try to match the fonts with the design.
I'd ask @danielmarquespt here because I tend to reuse our existing components for UI uniformity instead of making many custom components that differ from each other, while effectively being the same thing. |
Visually I prefer the new design, but being pragmatic I prefer we use the existing component instead of adding yet another style. Rule of thumb: Consistent but ugly > Pretty but inconsistent Also, keeping the same component allows for an easier fix in the future! |
Yep, agree, that's my position as well! Thanks! |
Test plan: Local sg run and tests. Storybook updated.
2ab7895 to
878afc8
Compare
Test plan: Local sg run and tests. Storybook.
Test plan: Local sg run and tests. Storybook.
Test plan:
Local sg run and tests.
Storybook updated.
Updated demo:
CleanShot.2023-04-13.at.1.34.51.mp4
App preview:
Check out the client app preview documentation to learn more.