This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search export: add modal for better UI, error handling, and transparency#50316
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 00b3bef...7a3a40d.
|
10 tasks
ee950db to
0f493e0
Compare
0f493e0 to
0417798
Compare
camdencheek
approved these changes
Apr 4, 2023
camdencheek
left a comment
Member
There was a problem hiding this comment.
Nice! This is a significant improvement. Thanks!
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
…ncy (#50316) Addresses a few issues in https://github.com/sourcegraph/sourcegraph/issues/49645 - Added a modal to show warnings and errors when doing export. - Warnings shown: - No global `type:` or `select:` filter - Search will be re-run - Search is not complete (this is blocking and will prevent export while results are still streaming) - The modal shows a progress indicator when export starts; once the export has started, the modal can't be closed. - If the original search did not reach the display limit (1500 results), there is no need for the search to be run again and those results are used for export. - If the re-run search produces an error, the modal stays open to show the error and the user can try again. - Once the export completes successfully, the modal is automatically closed and the file is downloaded. - Lowered the display limit for exported results to 100,000 since the previous limit of 1,000,000 was not working for some very generic queries (eg. `context:global count:all a`) on both dotcom and s2; the search would take several minutes and eventually the browser would close the connection. ## Test plan     ## App preview: - [Web](https://sg-web-jp-searchexportmodal.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more. (cherry picked from commit c1ce6c8)
coury-clark
pushed a commit
that referenced
this pull request
Apr 4, 2023
…, and transparency (#50348) Addresses a few issues in https://github.com/sourcegraph/sourcegraph/issues/49645 - Added a modal to show warnings and errors when doing export. - Warnings shown: - No global `type:` or `select:` filter - Search will be re-run - Search is not complete (this is blocking and will prevent export while results are still streaming) - The modal shows a progress indicator when export starts; once the export has started, the modal can't be closed. - If the original search did not reach the display limit (1500 results), there is no need for the search to be run again and those results are used for export. - If the re-run search produces an error, the modal stays open to show the error and the user can try again. - Once the export completes successfully, the modal is automatically closed and the file is downloaded. - Lowered the display limit for exported results to 100,000 since the previous limit of 1,000,000 was not working for some very generic queries (eg. `context:global count:all a`) on both dotcom and s2; the search would take several minutes and eventually the browser would close the connection. ## Test plan     ## App preview: - [Web](https://sg-web-jp-searchexportmodal.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more. <br> Backport c1ce6c8 from #50316 Co-authored-by: Juliana Peña <me@julip.co>
almeidapaulooliveira
pushed a commit
that referenced
this pull request
Apr 5, 2023
…ncy (#50316) Addresses a few issues in https://github.com/sourcegraph/sourcegraph/issues/49645 - Added a modal to show warnings and errors when doing export. - Warnings shown: - No global `type:` or `select:` filter - Search will be re-run - Search is not complete (this is blocking and will prevent export while results are still streaming) - The modal shows a progress indicator when export starts; once the export has started, the modal can't be closed. - If the original search did not reach the display limit (1500 results), there is no need for the search to be run again and those results are used for export. - If the re-run search produces an error, the modal stays open to show the error and the user can try again. - Once the export completes successfully, the modal is automatically closed and the file is downloaded. - Lowered the display limit for exported results to 100,000 since the previous limit of 1,000,000 was not working for some very generic queries (eg. `context:global count:all a`) on both dotcom and s2; the search would take several minutes and eventually the browser would close the connection. ## Test plan     ## App preview: - [Web](https://sg-web-jp-searchexportmodal.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a few issues in https://github.com/sourcegraph/sourcegraph/issues/49645
type:orselect:filtercontext:global count:all a) on both dotcom and s2; the search would take several minutes and eventually the browser would close the connection.Test plan
App preview:
Check out the client app preview documentation to learn more.