This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add local storage persist layout for code insight dashboards#50301
Merged
Conversation
Contributor
Author
|
@coury-clark @chwarwick I also was thinking about having a button that will reset the standard grid sizes and order in case you completely messed up with your dashboard grid and want to get everything to the initial state. |
coury-clark
approved these changes
Apr 3, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5948de9...c0c3749. No notifications. |
3bd210d to
3916155
Compare
valerybugakov
approved these changes
Apr 5, 2023
almeidapaulooliveira
pushed a commit
that referenced
this pull request
Apr 6, 2023
Partially closes https://github.com/sourcegraph/sourcegraph/issues/29960 This PR adds local storage based persist logic for the code insight dashboard grid system. Here are a few thoughts to keep in mind about this change - First of all, it doesn't close https://github.com/sourcegraph/sourcegraph/issues/29960 completely because it uses just your local storage, so it's possible that the same dashboard will be in different modes if you're looking at this from two different browsers - All insights dashboard doesn't support order, and size persist because pagination and generic content of this dashboard requires more changes that we can't afford at the moment - Remember that our current grid system (even before this PR) doesn't support compact horizontal logic, so it's possible to see gaps between gaps. It works vertically, though, but it doesn't work for x-axes. Also requires some time to improve this ## Test plan - Go to any code insights dashboard - Change size and order - Refresh the page or go away from this dashboard and go back to it - Check that insights are in the same places where you put them last time - Add new insights and remove some insights from the dashboard - Grid system shouldn't be broken after all actions (add/remove) - Check that "reset grid layout" button resets grid cards order and sizes and after refresh you see no custom layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially closes https://github.com/sourcegraph/sourcegraph/issues/29960
This PR adds local storage based persist logic for the code insight dashboard grid system. Here are a few thoughts to keep in mind about this change
Test plan
App preview:
Check out the client app preview documentation to learn more.