Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: remove user tags functionality.#50051

Merged
sashaostrikov merged 2 commits into
mainfrom
main-dry-run/ao/chore/remove-tags
Mar 29, 2023
Merged

chore: remove user tags functionality.#50051
sashaostrikov merged 2 commits into
mainfrom
main-dry-run/ao/chore/remove-tags

Conversation

@sashaostrikov

@sashaostrikov sashaostrikov commented Mar 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sashaostrikov sashaostrikov self-assigned this Mar 28, 2023
@cla-bot cla-bot Bot added the cla-signed label Mar 28, 2023
@sashaostrikov sashaostrikov force-pushed the main-dry-run/ao/chore/remove-tags branch from e402af4 to c9dca9b Compare March 28, 2023 09:50
@sashaostrikov sashaostrikov requested review from a team and mrnugget March 28, 2023 13:40
@sashaostrikov sashaostrikov marked this pull request as ready for review March 28, 2023 13:40
@sourcegraph-bot

sourcegraph-bot commented Mar 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 7fad094...ac7de3c.

Notify File(s)
@BolajiOlajide client/web/src/integration/batches.test.ts
@courier-new client/web/src/integration/batches.test.ts
@eseliger client/web/src/integration/batches.test.ts
@limitedmage client/web/src/enterprise/code-monitoring/testing/util.ts
client/web/src/integration/search-aggregation.test.ts
client/web/src/integration/search.test.ts
@philipp-spiess client/jetbrains/webview/src/sourcegraph-api-access/api-gateway.ts
@unknwon dev/authtest/site_admin_test.go
enterprise/internal/database/perms_store.go
@vdavid client/jetbrains/webview/src/sourcegraph-api-access/api-gateway.ts

@sourcegraph-bot-devx sourcegraph-bot-devx mentioned this pull request Mar 28, 2023
Closed
68 tasks
mrnugget
mrnugget approved these changes Mar 28, 2023
View reviewed changes

@mrnugget mrnugget left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a follow-up ticket to ensure that we drop the column in next release?

Comment thread CHANGELOG.md Outdated
@sashaostrikov

sashaostrikov commented Mar 29, 2023

Copy link
Copy Markdown
Contributor Author

Can you create a follow-up ticket to ensure that we drop the column in next release?

already there :)
https://github.com/sourcegraph/sourcegraph/issues/50069

@sashaostrikov @mrnugget
Update CHANGELOG.md
ac7de3c 
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
@sashaostrikov sashaostrikov merged commit d0c99a9 into main Mar 29, 2023
@sashaostrikov sashaostrikov deleted the main-dry-run/ao/chore/remove-tags branch March 29, 2023 07:53
@enriquegh enriquegh mentioned this pull request Apr 7, 2023
Closed
philipp-spiess pushed a commit that referenced this pull request Apr 11, 2023
@sashaostrikov @mrnugget @philipp-spiess
chore: remove user tags functionality. (#50051)
45bd77e 
Test plan:
CI.

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mrnugget mrnugget mrnugget approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sashaostrikov sashaostrikov

Labels

cla-signed debt Technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove database-backed user feature "tags"

3 participants

@sashaostrikov @sourcegraph-bot @mrnugget