This repository was archived by the owner on Sep 30, 2024. It is now read-only.
searcher: always call Wait on comby processes#50034
Merged
Merged
Conversation
If you call Start you _must_ always call Wait to free up resources. In particular this is the likely cause of a huge goroutine leak in the searcher process which all blames to the os/exec package waiting on a context. This was an accidental regression introduced when this code was ported to using conc. Previously it would always call Wait, but now if something in the introduced pool fails, we don't call Wait. Test Plan: CI
eseliger
approved these changes
Mar 27, 2023
auto-merge was automatically disabled
March 28, 2023 11:19
Merge could not be authorized
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
If you call Start you _must_ always call Wait to free up resources. In particular this is the likely cause of a huge goroutine leak in the searcher process which all blames to the os/exec package waiting on a context. This was an accidental regression introduced when this code was ported to using conc. Previously it would always call Wait, but now if something in the introduced pool fails, we don't call Wait. Test Plan: CI (cherry picked from commit 257ba04)
keegancsmith
added a commit
that referenced
this pull request
Apr 3, 2023
If you call Start you _must_ always call Wait to free up resources. In particular this is the likely cause of a huge goroutine leak in the searcher process which all blames to the os/exec package waiting on a context. This was an accidental regression introduced when this code was ported to using conc. Previously it would always call Wait, but now if something in the introduced pool fails, we don't call Wait. Test Plan: CI Backport 257ba04 from #50034 Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you call Start you must always call Wait to free up resources. In particular this is the likely cause of a huge goroutine leak in the searcher process which all blames to the os/exec package waiting on a context.
This was an accidental regression introduced when this code was ported to using conc. Previously it would always call Wait, but now if something in the introduced pool fails, we don't call Wait.
Test Plan: CI
Likely fix for https://github.com/sourcegraph/sourcegraph/issues/49987