This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: use -z for ListFiles#50023
Merged
Merged
Conversation
If you do not pass -z to git ls-tree, it will quote filenames which contain special characters. This API isn't used much, so we have never noticed this issue before (most client code uses LsFiles). However, we Cody is using this API, and that is how we noticed it. Autoindexing uses it, and likely didn't encounter issues because the pattern passed in was likely specific enough to not include filenames with special characters. In the future we should look into unifying ListFiles and LsFiles, but they are different enough right now. Right now we copy-paste how LsFiles parses the output. Test Plan: added a test case
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 00ec5ff...efcaba3.
|
sashaostrikov
approved these changes
Mar 27, 2023
indradhanush
approved these changes
Mar 27, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
If you do not pass -z to git ls-tree, it will quote filenames which contain special characters. This API isn't used much, so we have never noticed this issue before (most client code uses LsFiles). However, we Cody is using this API, and that is how we noticed it. Autoindexing uses it, and likely didn't encounter issues because the pattern passed in was likely specific enough to not include filenames with special characters. In the future we should look into unifying ListFiles and LsFiles, but they are different enough right now. Right now we copy-paste how LsFiles parses the output. Test Plan: added a test case (cherry picked from commit 9e4963f)
keegancsmith
added a commit
that referenced
this pull request
Mar 28, 2023
If you do not pass -z to git ls-tree, it will quote filenames which contain special characters. This API isn't used much, so we have never noticed this issue before (most client code uses LsFiles). However, we Cody is using this API, and that is how we noticed it. Autoindexing uses it, and likely didn't encounter issues because the pattern passed in was likely specific enough to not include filenames with special characters. In the future we should look into unifying ListFiles and LsFiles, but they are different enough right now. Right now we copy-paste how LsFiles parses the output. Test Plan: added a test case Backport 9e4963f from #50023 Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you do not pass -z to git ls-tree, it will quote filenames which contain special characters. This API isn't used much, so we have never noticed this issue before (most client code uses LsFiles). However, we Cody is using this API, and that is how we noticed it. Autoindexing uses it, and likely didn't encounter issues because the pattern passed in was likely specific enough to not include filenames with special characters.
In the future we should look into unifying ListFiles and LsFiles, but they are different enough right now. Right now we copy-paste how LsFiles parses the output.
Test Plan: added a test case