This repository was archived by the owner on Sep 30, 2024. It is now read-only.
export series metadata with raw debug#49473
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d391344...6287545.
|
chwarwick
reviewed
Mar 16, 2023
chwarwick
left a comment
Contributor
There was a problem hiding this comment.
Change looks good, but not sure if that siticed-migration-graph.json should be there.
chwarwick
approved these changes
Mar 16, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
Closes https://github.com/sourcegraph/sourcegraph/issues/49446 1. Adds the entire insight series row to the raw debug endpoint 2. Fixes a bug where errors were not marshalling because they were private fields ## Test plan Running locally, hit the `insightViewDebug` endpoint and got this: ``` json { "data": { "insightViewDebug": { "raw": [ { "QueueStatus": { "SeriesId": "2Isekw8PhTksphApwp08gqzebUM", "Query": "type:commit", "Enabled": false, "Errored": 0, "Processing": 0, "Queued": 0, "Failed": 0, "Completed": 2, "SearchErrors": null }, "Backfills": [ { "Info": { "Id": 65, "RepoIteratorId": 62, "EstimatedCost": 8000, "State": "completed", "StartedAt": "2022-12-13T23:41:11.80836Z", "CompletedAt": "2022-12-13T23:42:50.405542Z", "RuntimeDuration": null, "PercentComplete": 1, "NumRepos": 1 }, "Errors": [] } ], "SeriesMetadata": { "id": 65, "series_id": "2Isekw8PhTksphApwp08gqzebUM", "query": "type:commit", "created_at": "2022-12-13T23:41:04.135542", "oldest_historical_at": "2022-06-14T23:41:04.135543", "last_recorded_at": "2023-03-15T22:23:27.176747", "next_recording_after": "2023-03-16T22:23:27.176747", "deleted_at": null, "backfill_queued_at": "2022-12-13T23:41:04.145383", "last_snapshot_at": "2023-03-15T22:23:27.292943", "next_snapshot_after": "2023-03-16T00:00:00", "repositories": [ "github.com/sourcegraph/sourcegraph" ], "sample_interval_unit": "DAY", "sample_interval_value": 1, "generated_from_capture_groups": false, "generation_method": "search", "just_in_time": false, "group_by": null, "backfill_attempts": 0, "needs_migration": false, "backfill_completed_at": "2022-12-13T23:42:50.405542", "supports_augmentation": true, "repository_criteria": null } } ] } } } ``` <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> (cherry picked from commit 9f04c08)
sqs
pushed a commit
that referenced
this pull request
Mar 18, 2023
Closes https://github.com/sourcegraph/sourcegraph/issues/49446 1. Adds the entire insight series row to the raw debug endpoint 2. Fixes a bug where errors were not marshalling because they were private fields ## Test plan Running locally, hit the `insightViewDebug` endpoint and got this: ``` json { "data": { "insightViewDebug": { "raw": [ { "QueueStatus": { "SeriesId": "2Isekw8PhTksphApwp08gqzebUM", "Query": "type:commit", "Enabled": false, "Errored": 0, "Processing": 0, "Queued": 0, "Failed": 0, "Completed": 2, "SearchErrors": null }, "Backfills": [ { "Info": { "Id": 65, "RepoIteratorId": 62, "EstimatedCost": 8000, "State": "completed", "StartedAt": "2022-12-13T23:41:11.80836Z", "CompletedAt": "2022-12-13T23:42:50.405542Z", "RuntimeDuration": null, "PercentComplete": 1, "NumRepos": 1 }, "Errors": [] } ], "SeriesMetadata": { "id": 65, "series_id": "2Isekw8PhTksphApwp08gqzebUM", "query": "type:commit", "created_at": "2022-12-13T23:41:04.135542", "oldest_historical_at": "2022-06-14T23:41:04.135543", "last_recorded_at": "2023-03-15T22:23:27.176747", "next_recording_after": "2023-03-16T22:23:27.176747", "deleted_at": null, "backfill_queued_at": "2022-12-13T23:41:04.145383", "last_snapshot_at": "2023-03-15T22:23:27.292943", "next_snapshot_after": "2023-03-16T00:00:00", "repositories": [ "github.com/sourcegraph/sourcegraph" ], "sample_interval_unit": "DAY", "sample_interval_value": 1, "generated_from_capture_groups": false, "generation_method": "search", "just_in_time": false, "group_by": null, "backfill_attempts": 0, "needs_migration": false, "backfill_completed_at": "2022-12-13T23:42:50.405542", "supports_augmentation": true, "repository_criteria": null } } ] } } } ``` <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/49446
Test plan
Running locally, hit the
insightViewDebugendpoint and got this: