blob: make selection-driven nav default#48066
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 2fcaa89 and 397fe92 or learn more. Open explanation
|
|
This would be great. It would remove a lot of unused code paths! |
|
I rebased the PR https://github.com/sourcegraph/sourcegraph/pull/46059 (remove the extension API) on top of this. That removal significantly benefits from this change (thank you!). Do you plan to merge this PR in the next few days (or at least in the next 1-2 weeks)? Just wondering so I can plan to complete that PR by the next release. |
|
Great, @sqs! |
| // URL is updated | ||
| await driver.assertWindowLocation(`${filePaths['test.ts']}?L1-3`) | ||
| }) | ||
|
|
There was a problem hiding this comment.
Removing tests for not supported behavior.
With the current selection-driven nav implementaion clicking (shift-clicking) only line numbers select line (ranges).
Clicking on the line content has no effect. Shift-clicking lines selects lines content.
Screen.Recording.2023-02-27.at.14.41.49.mov
philipp-spiess
left a comment
There was a problem hiding this comment.
Don't forget to add a changelog but this is 🕶️
…yemets/cm-blob-cleanup # Conflicts: # client/web/src/repo/blob/BlobPage.tsx # client/web/src/repo/blob/CodeMirrorBlob.tsx # client/web/src/repo/blob/backend.ts
In the web app, the new selection-driven code nav UI (https://github.com/sourcegraph/sourcegraph/pull/44698 https://github.com/sourcegraph/sourcegraph/pull/48066) does not use this. The browser extension's implementation is separate from the web app's in implementation and backstory, but it is also removed because it presents the same future UX problems and is inconsistent with the direction we're taking for the web app. ## Test plan Ensure code navigation in the remaining selection-driven mode still works.
Selection-driven navigation has been dogfooded on dotcom and s2 instances for a while, so significant issues should have been addressed already. It's relatively safe to remove link-driven (not widely used) and hover-only code navigation implementation and leave selection-driven as the only way to navigate the blob view.
It was suggested initially to leave a fallback option, but hover-only navigation was not used internally for a while and we probably can't be sure if it is still fully functional given the amount of recent CodeMirror blob config changes.
Feedback is highly appreciated!
Screen.Recording.2023-02-23.at.17.34.10.mov
Test plan