This repository was archived by the owner on Sep 30, 2024. It is now read-only.
remove "click to go to definition" behavior#48687
Merged
Merged
Conversation
In the web app, the new selection-driven code nav UI (https://github.com/sourcegraph/sourcegraph/pull/44698) does not use this. The browser extension's implementation is separate from the web app's in implementation and backstory, but it is also removed because it presents the same future UX problems and is inconsistent with the direction we're taking for the web app.
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 7fcaf0b and 984bdaa or learn more. Open explanation
|
vdavid
approved these changes
Mar 6, 2023
vdavid
left a comment
Contributor
There was a problem hiding this comment.
From a front-end POV, it LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the web app, the new selection-driven code nav UI (https://github.com/sourcegraph/sourcegraph/pull/44698 https://github.com/sourcegraph/sourcegraph/pull/48066) does not use this.
The browser extension's implementation is separate from the web app's in implementation and backstory, but it is also removed because it presents the same future UX problems and is inconsistent with the direction we're taking for the web app.
Test plan
Ensure code navigation in the remaining selection-driven mode still works.