Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Render .txt readme files#47944

Merged
philipp-spiess merged 2 commits into
mainfrom
ps/render-txt-readme
Feb 22, 2023
Merged

Render .txt readme files#47944
philipp-spiess merged 2 commits into
mainfrom
ps/render-txt-readme

Conversation

@philipp-spiess

@philipp-spiess philipp-spiess commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Part of #44627

This PR adds support for also rendering readme.txt files (ignoring the casing) as part of the README logic as reported here.

Test plan

Tested locally with a file that overflows

Screenshot 2023-02-21 at 12 06 00

App preview:

Check out the client app preview documentation to learn more.

@philipp-spiess philipp-spiess requested review from a team, beyang and olafurpg February 21, 2023 11:11
@philipp-spiess philipp-spiess self-assigned this Feb 21, 2023
@cla-bot cla-bot Bot added the cla-signed label Feb 21, 2023
@github-actions github-actions Bot added the team/code-exploration Issues owned by the Code Exploration team label Feb 21, 2023
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Feb 21, 2023

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.50 kb) 0.00% (+0.50 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits c0c0f1b and 9d4dbba or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@valerybugakov valerybugakov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@philipp-spiess philipp-spiess enabled auto-merge (squash) February 22, 2023 09:47
@philipp-spiess philipp-spiess merged commit 8bfb202 into main Feb 22, 2023
@philipp-spiess philipp-spiess deleted the ps/render-txt-readme branch February 22, 2023 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/code-exploration Issues owned by the Code Exploration team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants