This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Build 3rd party Wolfi images#47368
Merged
Merged
Conversation
a3a4b2f to
503db97
Compare
ed02326 to
aa369c9
Compare
Based on our existing postgres-12-alpine dockerfile's config
180be76 to
6e37924
Compare
This breaks in the latest apko version
This isn't the ideal solution for building these images - see sourcegraph/security#570 (comment) for alternatives
This is an upgrade from v0.11 -> v0.12
These labels are added in the wolfi base image
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff aa369c9...6e5546f.
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff aa369c9...6e5546f.
|
willdollman
added a commit
that referenced
this pull request
Apr 20, 2023
This PR migrates our 3rd party docker images from docker-images/ to Wolfi. https://github.com/sourcegraph/sourcegraph/pull/47182 tracks our 1st party images in `cmd/`. ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> - Manual testing - These images will not be live once merged, and will undergo full validation before this happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates our 3rd party docker images from docker-images/ to Wolfi.
The counterpart to this is https://github.com/sourcegraph/sourcegraph/pull/47182 which tracks our 1st party images in
cmd/.There are 19 images to migrate here - many need custom base images and dependencies packaged:
Test plan