Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

insights: allow to save the default number of series samples#47329

Merged
leonore merged 11 commits into
mainfrom
insights/save-num-samples-filter
Feb 8, 2023
Merged

insights: allow to save the default number of series samples#47329
leonore merged 11 commits into
mainfrom
insights/save-num-samples-filter

Conversation

@leonore

@leonore leonore commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

closes #46283

Test plan

Added store unit test. Added integration test

cd dev/gqltest && go test -long -run TestUpdateInsight -base-url "https://sourcegraph.test:3443" -v

Manually tested:

Screen.Recording.2023-02-02.at.17.09.04.mov

@leonore leonore requested a review from a team February 2, 2023 17:11
@cla-bot cla-bot Bot added the cla-signed label Feb 2, 2023
@leonore leonore marked this pull request as ready for review February 2, 2023 17:11
@sourcegraph-bot

sourcegraph-bot commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff e2ede87...f776219.

Notify File(s)
@sourcegraph/code-insights-backend enterprise/internal/insights/store/insight_store.go
enterprise/internal/insights/store/insight_store_test.go
enterprise/internal/insights/types/types.go
@unknwon dev/gqltest/code_insights_test.go
internal/gqltestutil/code_insights.go

Comment thread enterprise/cmd/frontend/internal/insights/resolvers/insight_view_resolvers.go Outdated
Comment thread enterprise/cmd/frontend/internal/insights/resolvers/insight_series_resolver.go Outdated
@leonore leonore enabled auto-merge (squash) February 8, 2023 12:12
@leonore leonore merged commit d29091a into main Feb 8, 2023
@leonore leonore deleted the insights/save-num-samples-filter branch February 8, 2023 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insights: allow to save a default number of series samples to fetch

3 participants